Build plugin with vs2022/scons4.7 #22
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… classes Added methods to increase cycle and lifetime of Bullet, mostly for readability. Use getters/setters rather than fields in bullet kits
|
I'm not entirely sure what the best way is to get rid of the submodule update from this PR |
|
I'm not sure my changes are all correct. I'm not sure this is the intended behaviour. From the main page here on github I'd think not. |
Fixed setter for transform of dynamic_bullet
|
ok, I found the issue: by using the setter I was resetting the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is the PR related to #21
Made members of Bullet protected so they may be accessed in inherited classes
Added methods to increase cycle and lifetime of Bullet, mostly for readability. Use getters/setters rather than fields in bullet kits