-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use projectName()
instead of static PDX name?
#28
Comments
Ehy! Yes, using the project name for the final pdx would be ideal. The issue with it lies in the VSCode launch config file. Maybe we can fix that using an .env file, but that would mean having to maintain two files containing the project name. |
Oh, I honestly hadn't even seen the VSC launch file. That looks super useful! I'll pull that into my own code and see if I can figure out a solution for the name issue that doesn't involve a separate |
I messed around with this for a while locally. It seems like the easiest solution would be to make the {
// …
"args": [
"${workspaceFolder}/${workspaceFolderBasename}.pdx"
],
// …
} This assumes that the folder and |
Yeah seems reasonable enough. |
👋 figured I'd start with some easy feedback. It's very possible I'm just missing something. Right now when I build, the output is a
playdate.pdx
. That means when I upload to device via the sim, other apps with that PDX name get overwritten.It seems like this should be easy to change by updating the
bundlePDX
build proc to useprojectName()
:This change seems to work well for me locally, but I'm not sure whether there's a specific reason it's set up like this, so I figured I'd open an issue instead of just PRing.
The text was updated successfully, but these errors were encountered: