Fix diff lines that begin with -- or ++ #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dark-panda
force-pushed
the
fix-diffs-with-dashes-and-pluses
branch
3 times, most recently
from
cac9a92 to
cc0d1f8
Compare
We can leverage the file paths path to enhance our regex, since the odds of them matching exactly what appears in a diff output are pretty minimal.
dark-panda
force-pushed
the
fix-diffs-with-dashes-and-pluses
branch
from
cc0d1f8 to
c71e806
Compare
|
please merge it: it actually helps, I do use it. without this fix it is, frankly, of little use as it drops diffs. @dark-panda thanks 👍 |
|
Thank you for fixing this longstanding bug! |
|
Released in https://rubygems.org/gems/diffy/versions/3.3.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can leverage the file paths path to enhance our regex, since the odds
of them matching exactly what appears in a diff output are pretty minimal.
Fixes issues #77 and #92.