Support TypeScript nodenext module resolution #155
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using `nodenext` module resolution and there's an `exports` in the package.json, it requires a `types` field or else fails to resolve modules.
This adds `types` to `exports/./*` to resolve types for `import etc from 'fp-ts-std/etc'`, and changes the `.` import to an object so that types are correctly resolved for `import { etc } from 'fp-ts-std'`. Not sure why it didn't have an ESM import for `.` already, so added that too.
[Related TS issue](microsoft/TypeScript#49388)
|
I see this was tried in gcanti/fp-ts#1726 but then reverted so, 🤷 take it or leave it no big deal |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
nodenextmodule resolution and there's anexportsin the package.json, it requires atypesfield or else fails to resolve modules.This adds
typestoexports/./*to resolve types forimport etc from 'fp-ts-std/etc', and changes the.import to an object so that types are correctly resolved forimport { etc } from 'fp-ts-std'. Not sure why it didn't have an ESM import for.already, so added that too.Related TS issue