Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not produce a error if config file is not found #15

Closed
andrewsav-bt opened this issue Jul 5, 2018 · 2 comments
Closed

Does not produce a error if config file is not found #15

andrewsav-bt opened this issue Jul 5, 2018 · 2 comments

Comments

@andrewsav-bt
Copy link

andrewsav-bt commented Jul 5, 2018

The program does not produce any output if the config file is absent / not found. Is this supposed to happen?

UPDATE: hm... I can't see any error for example when a host name in the config file cannot be resolved, it's as if stderr does not exist at all... I wonder what I'm doing wrong...

@andrewsav-bt
Copy link
Author

Okay, I looked at the source code and

  1. It appears that if file cannot be found the program just do exit(1) without attempting to give a message. I suggest an improvement here to show a error.

  2. Program routinely logs to syslog. In particular parsing errors go to syslog. If I'm running in a docker container I do not have the syslog. So another suggested improvement is to have an option to log to stderr/stdout instead of syslog.

Thank you.

@samhocevar
Copy link
Owner

Thanks for the suggestions and sorry for acting so late on them. rinetd now only logs to syslog when forked to the background, otherwise it will use stderr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants