Fix clipping not being applied to the source in drawCanvas()
9-argument version
#179
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
drawCanvas()
test below should look like thedrawImage()
one above it. Same source image, same coordinates used, but source image first drawn another canvas at full size.The canvas'
Picture
can't be clipped, as far as I can tell, and there's noSkCanvs.draw_picture()
version that takes a clip, like withdraw_image_rect_..()
, so I clipped the destination canvas instead.This came up while I was working on SVG rendering and was doing a final check, expecting the current
Content2D.draw_picture()
to take care of things once given a Picture... then was surprised. Luckily thought to test withdrawCanvas()
first before assuming it had anything to do with SVG specifically.