Skip to content

Commit

Permalink
fix: add extra context to check interfaces script logs (ethereum-opti…
Browse files Browse the repository at this point in the history
…mism#11861)

Updates the output of the check-interfaces script to be more clear
about cases when removing items from the EXCLUDE_CONTRACTS list is
acceptable and how to verify that an item is unnecessary.
  • Loading branch information
smartcontracts authored and samlaf committed Nov 10, 2024
1 parent b54c9d7 commit 9f62910
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions packages/contracts-bedrock/scripts/checks/check-interfaces.sh
Original file line number Diff line number Diff line change
Expand Up @@ -219,8 +219,9 @@ done
# Check for unnecessary exclusions
for exclude_item in "${EXCLUDE_CONTRACTS[@]}"; do
if ! grep -q "^$exclude_item$" "$REPORTED_INTERFACES_FILE"; then
echo "Warning: $exclude_item is in the exclude list but was not reported as an issue."
echo "Consider removing it from the EXCLUDE_CONTRACTS list in the script."
echo "Warning: $exclude_item is in the exclude list but WAS NOT reported as an issue. It"
echo "may be unnecessary in the EXCLUDE_CONTRACTS list, but you MUST verify this before"
echo "removing it by performing a clean and full build before re-running this script."
fi
done

Expand Down

0 comments on commit 9f62910

Please sign in to comment.