update to master #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
```bash Fatal error: Namespace declaration statement has to be the very first statement or after any declare call in the script in psalm/stubs/imagick.php on line 11 ``` Recreate: `php -l psalm/stubs/imagick.php` Expect: `No syntax errors detected in psalm/stubs/imagick.php`
forgot the apostrophe Co-authored-by: Tom J Nowell <contact@tomjn.com>
…mp_dir' into improvement/use_wordpress_get_temp_dir * origin/improvement/use_wordpress_get_temp_dir: Update inc/namespace.php
As of PHP 8.0, substr will return empty string rather than false in certain circumstances.
Due to this change, this implementation of readdir in S3-Uploads behaves incorrectly. In particular, this common pattern:
while (($file = readdir($dh)) !== false){
which is used in gravityforms, becomes an infinite loop since the while loop just keeps getting an empty string rather than false.
This can lead to a crazy high AWS S3 list line item on your bill. I recommend merging in this change right away to avoid this situation.
…p_dir Use get_temp_dir instead of sys_get_temp_dir
fix readdir bug from PHP 8 substr change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.