Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropping URI.escape for Addressable::URI.encode as the former is no longer supported #5

Merged
merged 2 commits into from
Apr 29, 2022

Conversation

tylercrocker
Copy link
Contributor

Ruby 2.7 deprecated URI.escape and now in Ruby 3.x it's just gone.

@tylercrocker tylercrocker changed the title Dropping URI.escape for Addressable::URI.parse as the former is no longer supported Dropping URI.escape for Addressable::URI.encode as the former is no longer supported Apr 16, 2022
Copy link
Owner

@sampatbadhe sampatbadhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tylercrocker Looks good to me, thank you for PR.

@sampatbadhe sampatbadhe merged commit ee35d39 into sampatbadhe:master Apr 29, 2022
@sampatbadhe
Copy link
Owner

@tylercrocker released as 0.1.2

@tylercrocker
Copy link
Contributor Author

Awesome thanks!!

@sampatbadhe sampatbadhe mentioned this pull request Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants