Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Step 4 — Add webpack-subresource-integrity #5

Open
wants to merge 1 commit into
base: 03-less
Choose a base branch
from
Open

Step 4 — Add webpack-subresource-integrity #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@
"preact-compat-enzyme": "^0.2.5",
"preact-render-to-json": "^3.6.6",
"preact-test-utils": "^0.1.3",
"source-map-explorer": "^1.5.0"
"source-map-explorer": "^1.5.0",
"webpack-subresource-integrity": "^1.1.0-rc.4"
}
}
2 changes: 2 additions & 0 deletions scripts/build.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,9 @@ const babelConfig = require('babel-preset-react-app');
babelIE11(babelConfig);

const webpackPreact = require('./patch/webpackPreact');
const webpackSRI = require('./patch/webpackSRI');
const webpackConfig = require('react-scripts/config/webpack.config.prod');
webpackPreact(webpackConfig);
webpackSRI(webpackConfig);

require('react-scripts/scripts/build');
11 changes: 11 additions & 0 deletions scripts/patch/webpackSRI.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
const SriPlugin = require('webpack-subresource-integrity');

module.exports = webpackConfig => {
webpackConfig.plugins.push(
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be trickier if we had to add webpack plugins in a certain order, but this one needs to be the last one so we just push it to the Array of plugins.

new SriPlugin({
hashFuncNames: ['sha384'],
enabled: true
})
);
webpackConfig.output.crossOriginLoading = 'anonymous';
};
19 changes: 18 additions & 1 deletion yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6447,6 +6447,10 @@ source-list-map@^2.0.0:
version "2.0.0"
resolved "https://npm.tradeshift.net/repository/npm-all/source-list-map/-/source-list-map-2.0.0.tgz#aaa47403f7b245a92fbc97ea08f250d6087ed085"

source-list-map@~0.1.7:
version "0.1.8"
resolved "https://npm.tradeshift.net/repository/npm-all/source-list-map/-/source-list-map-0.1.8.tgz#c550b2ab5427f6b3f21f5afead88c4f5587b2106"

source-map-explorer@^1.5.0:
version "1.5.0"
resolved "https://npm.tradeshift.net/repository/npm-all/source-map-explorer/-/source-map-explorer-1.5.0.tgz#654e2ba0db158fecfc99b9cefdf891b755b767d1"
Expand Down Expand Up @@ -6484,7 +6488,7 @@ source-map@0.5.x, source-map@^0.5.1, source-map@^0.5.3, source-map@^0.5.6, sourc
version "0.5.7"
resolved "https://npm.tradeshift.net/repository/npm-all/source-map/-/source-map-0.5.7.tgz#8a039d2d1021d22d1ea14c80d8ea468ba2ef3fcc"

source-map@^0.4.4:
source-map@^0.4.4, source-map@~0.4.1:
version "0.4.4"
resolved "https://npm.tradeshift.net/repository/npm-all/source-map/-/source-map-0.4.4.tgz#eba4f5da9c0dc999de68032d8b4f76173652036b"
dependencies:
Expand Down Expand Up @@ -7201,6 +7205,13 @@ webidl-conversions@^4.0.0:
version "4.0.2"
resolved "https://npm.tradeshift.net/repository/npm-all/webidl-conversions/-/webidl-conversions-4.0.2.tgz#a855980b1f0b6b359ba1d5d9fb39ae941faa63ad"

webpack-core@^0.6.8:
version "0.6.9"
resolved "https://npm.tradeshift.net/repository/npm-all/webpack-core/-/webpack-core-0.6.9.tgz#fc571588c8558da77be9efb6debdc5a3b172bdc2"
dependencies:
source-list-map "~0.1.7"
source-map "~0.4.1"

webpack-dev-middleware@^1.11.0:
version "1.12.2"
resolved "https://npm.tradeshift.net/repository/npm-all/webpack-dev-middleware/-/webpack-dev-middleware-1.12.2.tgz#f8fc1120ce3b4fc5680ceecb43d777966b21105e"
Expand Down Expand Up @@ -7257,6 +7268,12 @@ webpack-sources@^1.0.1:
source-list-map "^2.0.0"
source-map "~0.6.1"

webpack-subresource-integrity@^1.1.0-rc.4:
version "1.1.0-rc.4"
resolved "https://npm.tradeshift.net/repository/npm-all/webpack-subresource-integrity/-/webpack-subresource-integrity-1.1.0-rc.4.tgz#c5c4e3d690f9d2f64a9550e07a8767f9796aa5d8"
dependencies:
webpack-core "^0.6.8"

webpack@3.8.1:
version "3.8.1"
resolved "https://npm.tradeshift.net/repository/npm-all/webpack/-/webpack-3.8.1.tgz#b16968a81100abe61608b0153c9159ef8bb2bd83"
Expand Down