199 Fix last line of verse disappearing when some lines get too long. #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… line of some verses.
… line of some verses.
…tinos-for-199-bug # Conflicts: # source/App.tsx # source/gui/screens/settings/components/SettingSwitchComponent.tsx # source/logic/db/models/Songs.ts
…irectly to settings screen
…tinos-for-199-bug # Conflicts: # source/App.tsx # source/gui/screens/settings/SettingsScreen.tsx # source/gui/screens/settings/components/SettingSwitchComponent.tsx
…tinos-for-199-bug
…tinos-for-199-bug # Conflicts: # ios/hymnbook2/Info.plist # package.json # source/gui/screens/songs/song/SongDisplayScreen.tsx # source/logic/db/models/Songs.ts
…ossible-solutinos-for-199-bug # Conflicts: # ios/hymnbook2/Info.plist # package.json # source/gui/screens/settings/SettingsScreen.tsx # source/gui/screens/settings/components/SettingSwitchComponent.tsx # source/gui/screens/songs/song/ContentVerse.tsx # source/gui/screens/songs/song/SongDisplayScreen.tsx # source/logic/db/models/songs/Songs.ts # source/settings.ts
…ightly too long and won't render.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To solve this, I use both callbacks and calculate which line will be rendered wrong. Then, that line I give an extra character \r (thus somehow increasing the line width by 4 pixels) so the difference between the line width and the container width is large enough that the system understand that this line needs to be wrapped.