Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

199 Fix last line of verse disappearing when some lines get too long. #282

Merged
merged 27 commits into from
Mar 10, 2025

Conversation

sampie777
Copy link
Owner

To solve this, I use both callbacks and calculate which line will be rendered wrong. Then, that line I give an extra character \r (thus somehow increasing the line width by 4 pixels) so the difference between the line width and the container width is large enough that the system understand that this line needs to be wrapped.

sampie777 and others added 27 commits March 18, 2024 13:06
…tinos-for-199-bug

# Conflicts:
#	source/App.tsx
#	source/gui/screens/settings/components/SettingSwitchComponent.tsx
#	source/logic/db/models/Songs.ts
…tinos-for-199-bug

# Conflicts:
#	source/App.tsx
#	source/gui/screens/settings/SettingsScreen.tsx
#	source/gui/screens/settings/components/SettingSwitchComponent.tsx
…tinos-for-199-bug

# Conflicts:
#	ios/hymnbook2/Info.plist
#	package.json
#	source/gui/screens/songs/song/SongDisplayScreen.tsx
#	source/logic/db/models/Songs.ts
…ossible-solutinos-for-199-bug

# Conflicts:
#	ios/hymnbook2/Info.plist
#	package.json
#	source/gui/screens/settings/SettingsScreen.tsx
#	source/gui/screens/settings/components/SettingSwitchComponent.tsx
#	source/gui/screens/songs/song/ContentVerse.tsx
#	source/gui/screens/songs/song/SongDisplayScreen.tsx
#	source/logic/db/models/songs/Songs.ts
#	source/settings.ts
@sampie777 sampie777 linked an issue Mar 10, 2025 that may be closed by this pull request
@sampie777 sampie777 merged commit 9a6ec22 into develop Mar 10, 2025
@sampie777 sampie777 linked an issue Mar 10, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create debug version for fixes for #199 [bug] Last line of verse disappears
1 participant