Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure we return 422 on non-existing measure POST requests (Fixes #512) #2008

Merged
merged 1 commit into from
Sep 3, 2024
Merged

Make sure we return 422 on non-existing measure POST requests (Fixes #512) #2008

merged 1 commit into from
Sep 3, 2024

Conversation

allentiak
Copy link
Member

@allentiak allentiak commented Sep 3, 2024

module: operation-evaluate-measure

  • apply parinfer-required formatting
  • add failing POST regression test for Fix Status Code of Type-Level $evaluate-measure Operation #512
  • major refactoring: tests: separate handler instance tests from handler
    type tests (WIP)
  • add missing test for "with missing measure parameter" POST requests
  • other minor refactorings

@allentiak allentiak marked this pull request as draft September 3, 2024 14:51
@allentiak allentiak marked this pull request as ready for review September 3, 2024 15:03
@alexanderkiel alexanderkiel self-assigned this Sep 3, 2024
Copy link

codecov bot commented Sep 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.96%. Comparing base (7e5533c) to head (a0e55c4).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2008   +/-   ##
=======================================
  Coverage   94.95%   94.96%           
=======================================
  Files         320      320           
  Lines       19692    19699    +7     
  Branches      462      462           
=======================================
+ Hits        18699    18707    +8     
+ Misses        531      530    -1     
  Partials      462      462           

see 3 files with indirect coverage changes

…512)

module: operation-evaluate-measure
* apply parinfer-required formatting
* add failing POST regression test for #512
* major refactoring: tests: separate handler instance tests from handler
type tests (WIP)
* add missing test for "with missing measure parameter" POST requests
* other minor refactorings
@alexanderkiel alexanderkiel added the bug Something isn't working label Sep 3, 2024
@alexanderkiel alexanderkiel added this pull request to the merge queue Sep 3, 2024
Merged via the queue into samply:main with commit bedf203 Sep 3, 2024
126 checks passed
@allentiak allentiak deleted the 512--post-requests-should-return-422 branch September 4, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working module:evaluate-measure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants