Add blank.mp4 to dist files #545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For a complete "offline" experience, it's necessary to self-host the file, so include it in the dist files for that purpose.
sampotts
approved these changes
Mar 25, 2017
|
A cleaner approach could be to include the file in the form of a data-uri, in which case, the |
|
I had that before - there was a reason I reverted to the remote file. I can't remember why... |
|
Okay, then let's keep it like this. I'm fine with it. |
|
Merged to |
filips123
pushed a commit
to filips123/plyr
that referenced
this pull request
Nov 22, 2018
Add blank.mp4 to dist files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to related issue (if applicable)
#504
Sumary of proposed changes
For a complete "offline" experience, it's necessary to self-host the file, so include it in the dist files for that purpose.