Brilift: Conformant float printing
#219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes Brilift conform to the new spec in #218 for printing all floats with 17 decimal digits of precision. Now all the float tests pass.
|
As I'm passing through, I was curious about the failing test. Am I correct in assuming that |
|
That is a problem, although I didn't mean to include a target at all (and there's another problem somewhere else). (GCC is not a "cross-compiler by default" like Clang is, so you actually have to build a special GCC for compiling to non-native architectures.) |
|
Alright; I think everything's in order! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just makes Brilift conform to the new spec in #218 for printing all floats with 17 decimal digits of precision. Now all the float tests pass!
Hoping to tack CI stuff on to this PR…