Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shortcodes method is not fluent #17

Closed
samrap opened this issue Apr 27, 2017 · 0 comments
Closed

Shortcodes method is not fluent #17

samrap opened this issue Apr 27, 2017 · 0 comments
Assignees
@samrap
Labels
bug

Comments

@samrap
Copy link
Owner

samrap commented Apr 27, 2017 •
edited
Loading

The builder shortcodes method does not return a builder instance.

The Builder's fluent interface should always return $this for every builder method. The shortcodes method was missing this and causing a runtime error. All tests should be updated to ensure $this is returned.
@samrap samrap added the bug label Apr 27, 2017
@samrap samrap self-assigned this Apr 27, 2017
samrap pushed a commit that referenced this issue Apr 27, 2017
Builder::shortcodes() does not return self (#17).
079fb3c
@samrap samrap closed this as completed in 1f787c9 Apr 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@samrap samrap

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@samrap