CSS issue if importing some svelte in contentScript AND in options

[HugoGresse]

I wanted to have a common TabBar.svelte used in the contentScript app as well as in the options App.

So the file architecture look like

/entries/contentScript/primary/App.svelte (import ~/lib/TabBar.svelte)
/entries/options/App.svelte (import ~/lib/TabBar.svelte)
/lib/TabBar.svelte

The issue is as soon as the options App.svelte import the TabBar, the contentScript/primary/main.z2EEd.css is not longer generated upon build.
For know I'm duplicating the file to prevent this issue, I've no clue how to fix this correctly though.

My repo is here: https://github.com/HugoGresse/app-store-review-templates
You'll need to import the App.svelte from the contentScript into options/App.svelte

[samrum]

Thanks for the repo that demonstrates the issue! I have a branch that refactors the way chunk assets are processed for Vite 2.9 here that may fix it. I can test it with your repo later.

[HugoGresse]

I can test it quickly as soon as you release a snapshot! The repo does not directly reproduce the issue, you'll need to remove the duplicate file from lib/ and change the import in options/App.svelte

[samrum]

I checked and made some tweaks to that branch and it'll fix that issue. It'll be part of an upcoming 1.0.0 release, though there are some breaking changes that'll require some small code changes on your end.

[HugoGresse]

I can manage that! thank you!

[HugoGresse]

I can confirm the version 1.0.2 does fix the issue. Thanks!

[HugoGresse]

If you release a snapshot I could test tomorrow! Le mer. 6 avr. 2022 à 00:27, Ruben Medina ***@***.***> a écrit :

…

Thanks for the repo that demonstrates the issue! I have a branch that refactors the way chunk assets are processed for Vite 2.9 here <https://github.com/samrum/vite-plugin-web-extension/tree/vite-2.9.0> that may fix it. I can test it with your repo later. — Reply to this email directly, view it on GitHub <#12 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAFBW2JL2HT5CM6VNRWQW5LVDS45DANCNFSM5SUBLWVQ> . You are receiving this because you authored the thread.Message ID: ***@***.***>