This repository has been archived by the owner on Jan 8, 2024. It is now read-only.
r/aws_rds_cluster_parameter_group and r/aws_db_parameter_group: Resto… #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re ability to change parameter values References: * hashicorp/terraform-provider-aws#11846 * hashicorp/terraform-provider-aws#11540 In #11540, support was added to the rds parameter group resources for resetting parameter values to AWS defaults when parameters are removed from config. A side-effect of these changes, however, was that parameters which remain in the config but whose values have been changed would also be reset to AWS defaults. This commit restores the ability for parameter values to be updated in the config while retaining the ability for parameters being removed from the config to be reset to AWS defaults. Output from acceptance testing: ``` make testacc TEST=./aws TESTARGS='-run=TestAccAWSDBClusterParameterGroup_' ... --- PASS: TestAccAWSDBClusterParameterGroup_disappears (18.01s) --- PASS: TestAccAWSDBClusterParameterGroup_namePrefix (23.28s) --- PASS: TestAccAWSDBClusterParameterGroup_only (23.40s) --- PASS: TestAccAWSDBClusterParameterGroup_generatedName (23.42s) --- PASS: TestAccAWSDBClusterParameterGroup_generatedName_Parameter (23.77s) --- PASS: TestAccAWSDBClusterParameterGroup_namePrefix_Parameter (23.79s) --- PASS: TestAccAWSDBClusterParameterGroup_withApplyMethod (23.89s) --- PASS: TestAccAWSDBClusterParameterGroup_basic (86.64s) --- PASS: TestAccAWSDBClusterParameterGroup_updateParameters (24.48s) ``` ``` make testacc TEST=./aws TESTARGS='-run=TestAccAWSDBParameterGroup_' ... --- PASS: TestAccAWSDBParameterGroup_Disappears (18.18s) --- PASS: TestAccAWSDBParameterGroup_generatedName (22.40s) --- PASS: TestAccAWSDBParameterGroup_namePrefix (22.69s) --- PASS: TestAccAWSDBParameterGroup_Only (23.40s) --- PASS: TestAccAWSDBParameterGroup_MatchDefault (24.19s) --- PASS: TestAccAWSDBParameterGroup_withApplyMethod (25.23s) --- PASS: TestAccAWSDBParameterGroup_limit (45.08s) --- PASS: TestAccAWSDBParameterGroup_basic (75.38s) --- PASS: TestAccAWSDBParameterGroup_updateParameters (30.10s) ```
|
Do we need to merge this into master? Can we just pull from this branch? |
|
Yup, we can do that. Just wanted to stage it in a public area where people can see. |
|
I'll just keep this on the branch rather than merging |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This repo is a fork of https://github.com/terraform-providers/terraform-provider-aws at version 2.70.0, the last version that supports tf 0.11.
This PR pulls in hashicorp/terraform-provider-aws#12112 as a step toward resolving https://samsaradev.atlassian.net/browse/RE-636
After this PR, I'll build a custom terraform provider binary and switch our aws pipelines to use the custom provider instead of the official terraform AWS provider. I'll wait for https://github.com/samsara-dev/backend/pull/79079 before doing that.