forked from ESCOMP/CTSM
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update build namelist checks for valid landuse v2 mode combinations #1
Merged
samsrabin
merged 15 commits into
samsrabin:fates-landuse-v2
from
glemieux:fates-landuse-v2-modechecks
May 7, 2024
Merged
Update build namelist checks for valid landuse v2 mode combinations #1
samsrabin
merged 15 commits into
samsrabin:fates-landuse-v2
from
glemieux:fates-landuse-v2-modechecks
May 7, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this also temporarily removes the use_fates_lupft check for the use_fates_luh namelist defaults
The basic fates landuse v2 build namelist options should be all set, but I need to flesh out the graceful failure checks and add unit tests to exercise them. To do:
|
Mode checks:
|
samsrabin
pushed a commit
that referenced
this pull request
May 9, 2024
new passing of 10m wind explicitly to ww3 -
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This ports changes made via https://github.com/glemieux/E3SM/tree/landuse-v2-modechecks to ctsm.
Specific notes
This adds a new switch
use_fates_lupft
to replace the previous checks onflandusepftdat
as well as adding new namelist build checks for valid fates run mode combinations includinguse_potentialveg
.Contributors other than yourself, if any: @ckoven
Testing performed, if any:
Build and run testing TBD