Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update build namelist checks for valid landuse v2 mode combinations #1

Merged

Conversation

glemieux
Copy link

@glemieux glemieux commented May 1, 2024

Description of changes

This ports changes made via https://github.com/glemieux/E3SM/tree/landuse-v2-modechecks to ctsm.

Specific notes

This adds a new switch use_fates_lupft to replace the previous checks on flandusepftdat as well as adding new namelist build checks for valid fates run mode combinations including use_potentialveg.

Contributors other than yourself, if any: @ckoven

Testing performed, if any:
Build and run testing TBD

@glemieux
Copy link
Author

glemieux commented May 5, 2024

The basic fates landuse v2 build namelist options should be all set, but I need to flesh out the graceful failure checks and add unit tests to exercise them.

To do:

  • add build namelist failure modes
  • add namelist unit tests

@glemieux
Copy link
Author

glemieux commented May 5, 2024

Mode checks:

use_fates_luh

  • use_fates_sp must be false
  • add fluh_timeseries and check

use_fates_potentialveg

  • use_fates_luh must be .true.
  • fates_harvest_mode must not be greater than zero

use_fates_lupft

  • use_fates_luh must be .true.
  • add flandusepftdat and check
  • use_fates_nocomp and use_fates_fixedbiogeog must be .true.

fates_harvest_mode

  • if greater than two use_fates_luh must be .true.

@samsrabin samsrabin merged commit 1ffa406 into samsrabin:fates-landuse-v2 May 7, 2024
samsrabin pushed a commit that referenced this pull request May 9, 2024
new passing of 10m wind explicitly to ww3 -
@glemieux glemieux deleted the fates-landuse-v2-modechecks branch May 23, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants