Modularization and more organized project structure #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samthor
reviewed
Apr 5, 2022
kuitos
reviewed
Apr 5, 2022
|
You are absolutely right, they are totally unnecessary, I've just removed them. |
kuitos
reviewed
Apr 6, 2022
package.json
Outdated
| "test": "npm run build:umd-polyfill && headless-test --cors test.js", | ||
| "closure": "google-closure-compiler --js=src/*.js --checks_only --module_resolution=node --compilation_level=ADVANCED", | ||
| "build": "run-p build:**", | ||
| "build:cjs": "rollup -i src/index.js -o lib/index.js -f cjs", |
There was a problem hiding this comment.
You could write a set of configuration in a single rollup.config.js file, rather than make a series npm scripts to do the same things:
export default {
{
input: 'src/index.js',
output: [
{
file: 'lib/index.js',
format: 'cjs'
},
{
file: 'es/index.js',
format: 'es'
}
]
}
}There was a problem hiding this comment.
so your build script can simplified to one line command "build": "rollup"
There was a problem hiding this comment.
Cool cool, didn't know that. Just updated the rollup config.
samthor
reviewed
Apr 8, 2022
| output: [ | ||
| { | ||
| file: 'dist/polyfill.js', | ||
| format: 'umd' |
There was a problem hiding this comment.
I'm still not convinced anyone actually wants umd, but there's probably no harm in it.
I guess I am a bit confused why umd doesn't get the document setup stuff that's in index.
samthor
approved these changes
Apr 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First PR of a series of changes proposed in #15, sorry for such delay. Modularization for portability and accessibility. Reorganizes project structure, and switches to
rollupas the builder to provide bothcjsandumdoutputs and better workflow for future development.