Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify description of structured vs unstructured meta-information lines #620

Merged
merged 4 commits into from
Aug 22, 2022

Commits on Jan 4, 2022

  1. Clarify structured vs unstructured meta-information lines

    Introduce the term "unstructured meta-information line", and reword this
    section so it describes the two flavours of meta-information line clearly.
    Specify that an unstructured value must not start with `<` (so that
    structured/unstructured are easily distinguished) and must be non-empty.
    
    Remove `<>` from unstructured `##pedigreeDB` example. PR samtools#88 removed
    the `<>` from one instance of `##pedigreeDB=<url>` presumably on the
    grounds that they were merely metasyntactic variable notation and not
    intended to appear literally, but missed this instance.
    jmarshall committed Jan 4, 2022
    Configuration menu
    Copy the full SHA
    cf4e7ac View commit details
    Browse the repository at this point in the history

Commits on Jan 5, 2022

  1. Remove <> from VCF test file ##pedigreeDB lines

    The specification now consistently reflects that `##pedigreeDB`'s value
    should not be delimited by angle brackets (despite being an URL!).
    
    Adjust the failed_meta_pedigreedb_002.vcf files as the claimed cause
    of failure is the invalid URL hostname rather than the angle brackets.
    jmarshall committed Jan 5, 2022
    Configuration menu
    Copy the full SHA
    6f8b89a View commit details
    Browse the repository at this point in the history

Commits on Jan 6, 2022

  1. Fix misleading ##pedigreeDB=<url> notation in older VCF specifications

    PR samtools#88 removed the `<>` from `##pedigreeDB=<url>` in VCFv4.3.tex,
    presumably on the grounds that they were merely metasyntactic variable
    notation and not intended to appear literally. As some readers still
    refer to these older documents, remove the misleading notation here too.
    jmarshall committed Jan 6, 2022
    Configuration menu
    Copy the full SHA
    a8e8c2a View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2022

  1. Configuration menu
    Copy the full SHA
    2da6d4e View commit details
    Browse the repository at this point in the history