Allow for UTF-8 field values in header regular expression #726
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
[:print:]
in the header regex and note that for ASCII it is equivalent to[ -~]
and that the aim is to forbid control characters. Fixes #719.To be honest, I'm tempted to add the extra
[]
to the\cclass
definition and waste a bit of space each time this appears rather than add the “For brevity” sentence.An alternative to this PR might be to just leave the regex as
[ -~]
and add a footnote explaining that this is an oversimplification for fields that allow Unicode values.