-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 4 CRAM compliance tests from htslib #1185
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1185 +/- ##
==============================================
+ Coverage 68.4% 68.409% +0.009%
- Complexity 8014 8030 +16
==============================================
Files 541 542 +1
Lines 32690 32769 +79
Branches 5529 5537 +8
==============================================
+ Hits 22360 22417 +57
- Misses 8126 8147 +21
- Partials 2204 2205 +1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jmthibault79 Adding these test seems like a good idea. Since all of the existing tests in the partialVerification
provider have corresponding tickets and a comment that explains the why they fail full verification, can we do that for the new ones ? Otherwise I feel like we're just adding more mystery. Especially if any of them fail 2.1 round tripping but succeed for 3.0. I'd lobby to not spend time on 2.1 round tripping failures, and just focus on 3.0.
As for c2#pad
and md#1
, I'd say the same thing (add them as tests, completely commented out since they fail even partial verification, and add a ticket the failure). Otherwise lets just delete them iif they're unreferenced.
Added links to issues to the 5 new failing tests, including |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding those @jmthibault79. @lbergelson this LGTM for merging once the tests pass.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. 👍
Description
Looking at htslib CRAM round trip, I noticed 6 that were missing from CramComplianceTest. These 4 pass with Partial Verification but need further investigation. Two others
c2#pad
andmd#1
are not included here because they do not pass Partial Verification.CRAM files generated using
samtools view
Checklist