-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding new overloads to IOUtils with Path for some file only methods #1296
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1296 +/- ##
===============================================
+ Coverage 67.508% 67.742% +0.234%
- Complexity 8148 8332 +184
===============================================
Files 557 560 +3
Lines 33384 33883 +499
Branches 5631 5751 +120
===============================================
+ Hits 22537 22953 +416
- Misses 8662 8727 +65
- Partials 2185 2203 +18
|
try( final Writer out = IOUtil.openFileForBufferedWriting(tmp)){ | ||
out.write(expected); | ||
} | ||
try( final BufferedReader in = IOUtil.openFileForBufferedReading(tmp)){ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you somehow check that the zipped files are really zipped and that the plaintext ones are really plaintext?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Co-Authored-By: lbergelson <louisb@broadinstitute.org>
@yfarjoun I responded to your comments, good to go? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no need for final
in TWR..also spaces
change spaces Co-Authored-By: lbergelson <louisb@broadinstitute.org>
Description
Add Path overloads of some functions in IOUtil that were missing them.
Fixes #1294
Checklist