CRAM: some structure test cleanup #1312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
git diffs are a mess, so it's probably easiest to view the whole files locally. |
Codecov Report
@@ Coverage Diff @@
## master #1312 +/- ##
==============================================
+ Coverage 67.75% 67.756% +0.006%
- Complexity 8235 8236 +1
==============================================
Files 562 562
Lines 33538 33538
Branches 5636 5636
==============================================
+ Hits 22722 22724 +2
+ Misses 8634 8632 -2
Partials 2182 2182
|
cmnbroad
approved these changes
Mar 1, 2019
src/test/java/htsjdk/samtools/cram/build/ContainerFactoryTest.java
Outdated
Show resolved
Hide resolved
|
|
||
| final int slice2AlignmentStart = 20; | ||
| final int slice2AlignmentSpan = 20; | ||
| final Slice slice2 = new Slice(mappedReferenceContext); |
There was a problem hiding this comment.
Minor suggestion to improve the readability of the code below: use mappedSlice as a prefix for these variables.
| new Slice(ReferenceContext.UNMAPPED_UNPLACED_CONTEXT), | ||
| new Slice(ReferenceContext.MULTIPLE_REFERENCE_CONTEXT) | ||
| }, | ||
| }; |
- ContainerTest, ContainerFactoryTest, ContainerParserTest, SliceTests, and CRAMBAIIndexerTest
jmthibault79
force-pushed
the
jt_test_cleanup
branch
from
eb5d0a0 to
cb6c6a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move common code from ContainerTest, ContainerFactoryTest, ContainerParserTest, SliceTests, CRAMBAIIndexerTest, and CramCompressionRecordUtil into new CRAMStructureTestUtil
Description
Test cleanup, as requested
Checklist