Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

typo in kh_int_hash_func2 definition #1598

Closed
fanxinping opened this issue Apr 6, 2023 · 1 comment · Fixed by #1599
Closed

typo in kh_int_hash_func2 definition #1598

fanxinping opened this issue Apr 6, 2023 · 1 comment · Fixed by #1599

Comments

@fanxinping
Copy link

htslib/khash.h line 450:

#define kh_int_hash_func2(k) __ac_Wang_hash((khint_t)key)

should be

#define kh_int_hash_func2(key) __ac_Wang_hash((khint_t)key)
@jkbonfield
Copy link
Contributor

Good catch. Looks like this was changed upstream in attractivechaos/klib@384277a

It's not something that any of our own code uses, so I'm not sure what the original author's intention was of adding this, but I'll make the trivial edit. Thanks

jkbonfield added a commit to jkbonfield/htslib that referenced this issue Apr 6, 2023
@jkbonfield
Fix typo in kh_int_hash_func2 macro.
43cf107 
This was fixed upstream in attractivechaos/klib@384277a

Fixes samtools#1598
@jkbonfield jkbonfield mentioned this issue Apr 6, 2023
Merged
daviesrob pushed a commit that referenced this issue Apr 18, 2023
@jkbonfield @daviesrob
Fix typo in kh_int_hash_func2 macro.
ca51cc5 
This was fixed upstream in attractivechaos/klib@384277a

Fixes #1598
daviesrob pushed a commit to daviesrob/htslib that referenced this issue Apr 18, 2023
@jkbonfield @daviesrob
Fix typo in kh_int_hash_func2 macro.
1682836 
This was fixed upstream in attractivechaos/klib@384277a

Fixes samtools#1598
vasudeva8 pushed a commit to vasudeva8/htslib that referenced this issue May 30, 2023
@jkbonfield @vasudeva8
Fix typo in kh_int_hash_func2 macro.
26d7b26 
This was fixed upstream in attractivechaos/klib@384277a

Fixes samtools#1598
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix typo in kh_int_hash_func2 macro. jkbonfield/htslib
2 participants
@jkbonfield @fanxinping