Permit BAM headers between 2GB and 4GB in size once more. #1421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This isn't permitted by the BAM specification, but was accepted by earlier htslib release. 62f9909 added code to check the maximum length. This now has a warning at 2GB and the hard-failure at 4GB. Fixes samtools#1420. Fixes samtools/samtools#1613
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This isn't permitted by the BAM specification, but was accepted by earlier htslib release. 62f9909 added code to check the maximum length. This now has a warning at 2GB and the hard-failure at 4GB.
Fixes #1420. Fixes samtools/samtools#1613
The problem still exists in CRAM, which also has signedness problems. It's not as trivial there as simply removing the check. (It will need CRAM v4.0 being adopted.)