Fix clang builds under mingw. #1435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note it fails the tests using gcc-12. I think these will be fixed by samtools/htscodecs#51, but haven't verified it. (Or alternatively use -O3 which is preferred anyway for htscodecs.) |
Under mingw clang requires dllexport to be applied to both function declarations and function definitions. (Gcc is happy for the definition only to have the dllexport attribute.) Note this exports several "internal" functions, including some apparently unused anywhere (hts_json_*). Perhaps they were once used in htslib-plugins, but no more. I haven't taken the decision to remove these though, but it's worth considering for whenever we next do an ABI breaking change. Either that or stop pretending that their internal only when clearly they are not, and move their API to the external htslib/*.h files instead. These appear to be somewhat in Limbo right now. Fixes samtools#1433
jkbonfield
added a commit
to jkbonfield/htslib
that referenced
this pull request
Aug 15, 2022
If we use HTSLIB_EXPORT once, it has to be used everywhere for that symbol. Also see samtools#1435
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Under mingw clang requires dllexport to be applied to both function
declarations and function definitions. (Gcc is happy for the
definition only to have the dllexport attribute.)
Note this exports several "internal" functions, including some
apparently unused anywhere (hts_json_*). Perhaps they were once used
in htslib-plugins, but no more.
I haven't taken the decision to remove these though, but it's worth
considering for whenever we next do an ABI breaking change. Either
that or stop pretending that their internal only when clearly they are
not, and move their API to the external htslib/*.h files instead.
These appear to be somewhat in Limbo right now.
Fixes #1433