time_funcs include and dependency adjustments #1474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix dependency typo in the Makefile Remove config.h from hts_time_funcs.h as it's likely to be too late to include it by the time that file it read. Add config.h include to test/test_time_funcs.c instead. Add extra includes to hts_time_funcs.h so it stands on its own and doesn't rely on the right headers having been included before it is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix dependency typo in the Makefile
Remove config.h from hts_time_funcs.h as it's likely to be too late to include it by the time that file it read. Add config.h include to test/test_time_funcs.c instead.
Add extra includes to hts_time_funcs.h so it stands on its own and doesn't rely on the right headers having been included before it is.