Add trivial le_to_u8() endianness routine #1494
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In writing a switch like this one in
bcf_fmt_array()
:htslib/vcf.c
Lines 2386 to 2392 in 8d91938
but in which the output types were unsigned rather than signed as in this one, I found that there was no
le_to_u8()
function. One could in fact just writeBRANCH(uint8_t, *, …)
in many such cases, but that is pretty obscure for the reader.This is even more trivial than
le_to_i8()
but can be useful for the regular treatment of unsigned types in these sorts of switches.