Make it easier to modify shared library permissions during install #1532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new LIB_PERM Makefile variable defaults to 644 (as before), but can now be amended to e.g. 755. Updated the INSTALL file with a section for HP-UX explaining how to do this. Fixes samtools#1525
|
It can already be equivalently overridden with |
|
Indeed, and I think I noted that in the issue. The comment was to make it "easier", which this most definitely does. Both easier for users, and inevitably easier for us as (assuming anyone actually uses it) we should get fewer issues caused by incorrect punctuation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new LIB_PERM Makefile variable defaults to 644 (as before), but can now be amended to e.g. 755. Updated the INSTALL file with a section for HP-UX explaining how to do this.
Fixes #1525