Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid bgzf EOF check on modern MinGW releases. #1601

Merged
merged 1 commit into from
May 16, 2023
Merged

Avoid bgzf EOF check on modern MinGW releases. #1601

merged 1 commit into from
May 16, 2023

Commits on Apr 18, 2023

  1. Fix fd_seek on pipes on modern MinGW releases. 

    MinGW 12.x started returning non-zero values from lseek when the fd
is a pipe.  This is unhelpful and it breaks bgzf_check_EOF as seeking
to the end is actually seeking to the end of the pipe memory buffer,
causing invalid EOFs.  (This breaks bcftools CI tests.)

Fixes samtools/bcftools#1901

Co-authored-by: John Marshall <jmarshall@hey.com>
    @jkbonfield @jmarshall
    jkbonfield and jmarshall committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    6efa19d View commit details
    Browse the repository at this point in the history