Fix hfile_libcurl small seek bug #1676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The commit and the explanation in the commit message look good. IMHO you should add a |
Ensure that `to_skip` is updated correctly when handling a small seek by skipping data in libcurl_read(). In particular, if the number of bytes returned by wait_perform() exactly matches the number left to skip, `to_skip` needs to be set to zero, and wait_perform() needs to be called again to get some data for the function to return. Co-Authored-By: Rob Davies <rmd+git@sanger.ac.uk>
daviesrob
force-pushed
the
small_seek
branch
from
84c0510
to
f0426df
Compare
|
Cheers. I've updated the commit message as suggested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that
to_skipis updated correctly when handling a small seek by skipping data in libcurl_read(). In particular, if the number of bytes returned by wait_perform() exactly matches the number left to skip,to_skipneeds to be set to zero, and wait_perform() needs to be called again to get some data for the function to return.Fixes samtools/samtools#1918; possibly also #1037, #1625 and samtools/samtools#1622
@jmarshall I've made you author of ths commit, as it was your patch. Let me know if you'd like to change anything before it gets merged.