Ensure S3 redirects use TLS #1762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When following a 3xx redirection from AWS, redirect_endpoint_callback() wasn't putting 'https://' on the new URL. The redirection worked, but dropped back to http. Fix by prepending 'https://' to ensure it uses TLS, and adding a bit of error checking to ensure all parts of the new url have been included.
|
To reproduce the problem, try: and look for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When following a 3xx redirection from AWS,
redirect_endpoint_callback()wasn't puttinghttps://on the new URL. The redirection worked, but dropped back to http. Obviously, this is not desirable.Fix by prepending
https://to ensure it uses TLS, and adding a bit of error checking to ensure all parts of the new url have been included.Fixes #1760