Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up faidx. #1797

Merged
merged 1 commit into from
Jul 8, 2024
Merged

Speed up faidx. #1797

merged 1 commit into from
Jul 8, 2024

Commits on Jun 27, 2024

  1. Speed up faidx.

    - bgzf_getc is slow as it's a heavy function and not inlined.  Most of
      the time though it's just an array fetch, so inline the basic form and
      revert to the function call for the complex form.
    
    - isgraph and all other ctype functions are slow.  We assume ASCII and
      just do a naive implementation.
    
    The speed benefits are (seconds):
    
                          Old     New
        Index GRCh38      13.4    8.4
        Query chr1	       1.7    0.9
    
    Given a significant speed change for a small localised modification it
    seems worth while having.
    jkbonfield committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    f6456e1 View commit details
    Browse the repository at this point in the history