Protect against negative POS fields in CRAM encoder. #1801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We check pos against the ref end, and if that fits we then fetch `&ref[apos]` to get the reference, but this understeps the array. The fastest way to handle all this and other related errors is simply to sanity check the input for out of bounds POS and bail out early. Credit to OSS-Fuzz Fixes oss-fuzz 70014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We check pos against the ref end, and if that fits we then fetch
&ref[apos]to get the reference, but this understeps the array.The fastest way to handle all this and other related errors is simply to sanity check the input for out of bounds POS and bail out early.
Credit to OSS-Fuzz
Fixes oss-fuzz 70014