od: remove long double #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rust does not have a the equivalent of the long double c type. od would required it to print long double. However, it does not work since the used crate, f128, does not have the same internal representation as long double. Therefore, simply drop the L SIZE for float types. Only float (-t fF or -t f) or double (-t fD) are supported. Signed-off-by: Valentin Longchamp <valentin@longchamp.me>
od was the only user for long double, that is dropped. Signed-off-by: Valentin Longchamp <valentin@longchamp.me>
|
Thanks for the PR @chlongv ! It'll be great to finally be rid of f128. Curious that the f128 version was buggy... that seems like an issue with c2rust. The CI error is my fault... I'll get that fixed ASAP. |
|
Ok, should be fixed in a1360f8 |
Have a look at this thread: rust-lang/rust-bindgen#1549 Doing some tests I have noticed the difference: with a binary 0.0 long double (confirmed with the "real" od), rustybox's od gave me nan (not a number). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove -t fL support for the od applet. It was anyhow non-functional as the use f128 representation was not compatible with the c representation, resulting in different results between rustybox and the classic od.
This allows to remove the f128 dependency as it is the only use of it and this should help for the cross-compilation that currently fails with f128.