Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement pytester_pretty fixture #8

Merged
merged 4 commits into from
Feb 1, 2023
Merged

Conversation

Czaki
Copy link
Contributor

@Czaki Czaki commented Jan 31, 2023

In this PR I implement my proposition from, fix #7

This adds the option to use this plugin with these projects that contains pytest fixtures and would validate if they working in a clean way.

It also adds a basic test for this project.

If it looks ok to you I will also add text to the readme.

Copy link
Owner

@samuelcolvin samuelcolvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise looking good.

return parseoutcomes


class PytesterWrapper:
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

again a docstring would be good.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added, could you check it?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

pytest_pretty/__init__.py Outdated Show resolved Hide resolved
pytest_pretty/__init__.py Outdated Show resolved Hide resolved
Copy link
Owner

@samuelcolvin samuelcolvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, I still think some type hints would make this much easier to read - doesn't have to be complete, but stuff like the return time of parseoutcomes would help a lot for future readers.

return parseoutcomes


class PytesterWrapper:
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@samuelcolvin samuelcolvin merged commit 8b5ea83 into samuelcolvin:main Feb 1, 2023
@samuelcolvin samuelcolvin changed the title Implement pytester_pretty fixture Implement pytester_pretty fixture Feb 1, 2023
@samuelcolvin
Copy link
Owner

thanks so much, I'll make a release now.

@Czaki Czaki deleted the pytester branch February 1, 2023 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add alternative for pytester fixture.
2 participants