-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement pytester_pretty
fixture
#8
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
otherwise looking good.
return parseoutcomes | ||
|
||
|
||
class PytesterWrapper: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
again a docstring would be good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added, could you check it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, I still think some type hints would make this much easier to read - doesn't have to be complete, but stuff like the return time of parseoutcomes
would help a lot for future readers.
return parseoutcomes | ||
|
||
|
||
class PytesterWrapper: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
pytester_pretty
fixture
thanks so much, I'll make a release now. |
In this PR I implement my proposition from, fix #7
This adds the option to use this plugin with these projects that contains pytest fixtures and would validate if they working in a clean way.
It also adds a basic test for this project.
If it looks ok to you I will also add text to the readme.