Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Login with environment variable #40

Merged
merged 6 commits into from
Mar 6, 2023
Merged

Login with environment variable #40

merged 6 commits into from
Mar 6, 2023

Conversation

mightymatth
Copy link
Contributor

@mightymatth mightymatth commented Mar 2, 2023 •
edited
Loading

fixes #36

@mightymatth
fix: input parameter, tests
204533a 
fix: removed package lock (using yarn)

Empty-Commit

fix: set credentials

fix: set credentials

fix: set credentials

Empty-Commit

fix: set credentials

fix: credentials

fix: credentials

fix: credentials

fix: credentials

fix: credentials

Empty-Commit

fix: credentials

Empty-Commit

fix: test

fix: test

fix: lint

fix: test

fix: test

fix: test

fix: test

fix: test

fix: test

fix: test

fix: test

fix: test

fix: test

fix: test

fix: test

fix: test

fix: test
@mightymatth mightymatth marked this pull request as ready for review March 3, 2023 10:37
@casperdcl casperdcl self-requested a review March 6, 2023 10:11
@casperdcl casperdcl added bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request dependencies Pull requests that update a dependency file labels Mar 6, 2023
@casperdcl casperdcl merged commit 0520656 into samuelmeuli:master Mar 6, 2023
@casperdcl
Copy link
Collaborator

Thanks @mightymatth!

@casperdcl casperdcl mentioned this pull request Mar 6, 2023
Closed
@mightymatth
Copy link
Contributor Author

Thanks for the cleanup. Definitely better. 🙌🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@casperdcl casperdcl Awaiting requested review from casperdcl

Assignees

@casperdcl casperdcl

@mightymatth mightymatth

Labels
bug Something isn't working dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

snapcraft login broke starting June 15, 2022
2 participants
@mightymatth @casperdcl