Antti/frontend #27

anttiasmala · 2024-05-17T15:21:23Z

Frontin parannukseen liittyvä PR. Liittyy issueen #26

…xt will me aligned on middle. Changed checkmark color to match the login button

vercel · 2024-05-17T15:21:26Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
lahjalista	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Sep 2, 2024 3:34pm

… credits_for_images.txt

… if scaling. Values are given as percentage, might be changed to rem

…t of the input bar's color

…bg color does not have to be set everytime

…ack does not work yet

…xtjs.org/docs/messages/no-img-element

…o component

…g one. I'm going to try to move these files into the correct branch antti/feedback-after-logout

…ely wrong one. I'm going to try to move these files into the correct branch antti/feedback-after-logout" This reverts commit fb04e6d.

anttiasmala

Lähdin vahingossa väsäämään palaute-systeemiä tähän branchiin. Netissä ehdotettiin käyttämään Gitin stashia tämmöisessä tilanteessa Tässä. Kerran yritin kokeilla stashin käyttöä, niin sain kadotettua koko koodin 😅

Siksi tein nyt näin, että tein commitin ja mergesin. En halunnut menettää tätä mitä jo aloin tekemään 😄

Täytyy stashin käyttöä harjoitella testimielessä, ei viitsi "oikealla" koodilla 😄

samuliasmala

Näyttää erinomaiselta! Muutama pieni kommentti, ja sitten vielä huomio että lintteri antaa yhden herjan minkä voisi korjata.

icons/arrow_right_start_on_rectangle.tsx

shared/isValidFunctions.ts

utils/fonts.ts

pages/_app.tsx

…laces

…ed anymore so code is a bit more clear

package.json

utils/fonts.ts

samuliasmala

components/InfoModal.tsx tiedostosta tulee lintteri-virhe.

Kysyin fontista Ullalta, ja jos designissa on Inter jossain käytössä niin se on vahinko -> poistetaan ja korvataan Jost:lla.

package.json

icons/arrow_right_start_on_rectangle.tsx

anttiasmala · 2024-09-02T14:55:16Z

components/InfoModal.tsx tiedostosta tulee lintteri-virhe.

Tarkistin samalla, tuo komponentti ei ole missään käytössä, joten poistoon vain 😄

Kysyin fontista Ullalta, ja jos designissa on Inter jossain käytössä niin se on vahinko -> poistetaan ja korvataan Jost:lla.

Jes, poistan tuon Interin kanssa 👍

…5.4.5 due to ESLint 8.57.0's last typescript version is apparently <5.5.0. ESLint version 9 does not work currently with Next's Lint check

…ther given color

anttiasmala · 2024-09-02T15:51:55Z

package.json

-    "typescript": "5.5.4",
+    "typescript": "5.4.5",


Tiputin Typescriptin version 5.5.4 -> 5.4.5. Tuo oli viimeisin kunnon päivitys, joka ei ollut >5.5.0. npmjs.com:n lista

Ajaessa npm run lint:fix tai npm run lint tuli tämmöinen virheilmoitus:

=============

WARNING: You are currently running a version of TypeScript which is not officially supported by @typescript-eslint/typescript-estree.

You may find that it works just fine, or you may not.

SUPPORTED TYPESCRIPT VERSIONS: >=4.7.4 <5.5.0

YOUR TYPESCRIPT VERSION: 5.5.4

Please only submit bug reports when using the officially supported version.

=============

Ei ollut apua vaikka @typescript-eslint/typescript-estree-paketin asensikin, sama virheilmoitus.

Sitten seuraava ongelma koskee ESLint 9:iä. Eli kun ESLintin päivittää (8.57.0 -> 9.9.1) tulee seuraava ongelma:

Could not resolve dependency: peer eslint@"^2 || ^3 || ^4 || ^5 || ^6 || ^7.2.0 || ^8" from eslint-plugin-import@2.29.1 node_modules/eslint-plugin-import dev eslint-plugin-import@"2.29.1" from the root project

Tätäkään en saanut korjattua

Myöskin ESLint 9:n ja Next Lintin kanssa on ollut hiukan ongelmaa vercel/next.js#64409

eslint-config-next-paketille oli tullut päivitys, mutta kyseisestä päivityksestä en löytänyt tietoa

Onko siis ihan ok mennä tällä tavalla nyt eteenpäin?

Koska Next.js ei vielä tue eslint v9, niin tuo mitä teit on paras ratkaisu.

Sitten seuraava ongelma koskee ESLint 9:iä. Eli kun ESLintin päivittää (8.57.0 -> 9.9.1) tulee seuraava ongelma:

Could not resolve dependency: peer eslint@"^2 || ^3 || ^4 || ^5 || ^6 || ^7.2.0 || ^8" from eslint-plugin-import@2.29.1 node_modules/eslint-plugin-import dev eslint-plugin-import@"2.29.1" from the root project

Tätäkään en saanut korjattua

Sitä ei oikein saakaan, kun ainakaan eslint-plugin-import ei tue vielä lainkaan eslint v9. Eli käytetään eslint v8 ja tuo TypeScriptin versio kunnes v9 tuki laajenee.

icons/pencil_edit.tsx

pages/index.tsx

components/InfoModal.tsx

samuliasmala

Nyt voi mergetä. Hienoa työtä! 💪

Kun olet mergennyt tämän main branchiin, niin mergeä sen jälkeen main branch antti/user-roles branchiin. Tällöin tulee mahdolliset merge confliktit ratkaistavaksi, ja mergen jälkeen #30 PR:ssä ei enää näy tämän frontti-PR:n muutoksia vaan pelkästään siihen kuuluvat muutokset.

anttiasmala added 6 commits April 27, 2024 21:39

Changed interactive-widget value

4e23abf

Removed unnecessary lines and added a small circle placeholder for logo

97d4d06

Added rounded value to input

712a95f

Added some color styling

5392df3

Added rounding to the Button

7388ad7

Added a group value for password. Added text-center so registering te…

1ad480d

…xt will me aligned on middle. Changed checkmark color to match the login button

anttiasmala changed the title ~~Antti/frontend~~ **WIP** Antti/frontend May 17, 2024

anttiasmala changed the title **WIP** Antti/frontend **WIP** | Antti/frontend May 17, 2024

anttiasmala linked an issue May 17, 2024 that may be closed by this pull request

7. Päivitetään ulkoasu designin mukaiseksi #26

Closed

anttiasmala added 12 commits May 29, 2024 16:02

Merged main branch into antti/frontend

a1ad9ef

Added logo with text and without text. Added the source of image into…

33197f4

… credits_for_images.txt

Change blue circle to the logo. Added some logic to make image follow…

39b0c1c

… if scaling. Values are given as percentage, might be changed to rem

Added password eye icon's default color to be white so it matches res…

c2dbeda

…t of the input bar's color

Added select-none to make the logo feel like a 'real logo'

cf0423b

Changed Button.tsx's bg color to match greenish color style. Now the …

aeb9cd8

…bg color does not have to be set everytime

Changed input's border color to be black

cc5aff8

changed interactive-widget in _app.tsx for now

1787e32

Created a page for logging out. Added some frontend code there. Feedb…

a84b533

…ack does not work yet

Changed receiver's and gift's input location

d9f428f

Added some styling to register page

4a9daba

Fixed 'No img element' error that Next.js gave. Reference: https://ne…

815e8a9

…xtjs.org/docs/messages/no-img-element

vercel bot deployed to Preview May 30, 2024 12:02 View deployment

anttiasmala added 2 commits May 30, 2024 15:13

Created a component from Logo. Changed old logo styles to use the Log…

14e62f7

…o component

ESLint fixes

6dcb3a8

vercel bot deployed to Preview May 30, 2024 12:14 View deployment

anttiasmala added 2 commits June 6, 2024 13:55

Started to do feedback branch in this branch which is complitely wron…

fb04e6d

…g one. I'm going to try to move these files into the correct branch antti/feedback-after-logout

Revert "Started to do feedback branch in this branch which is complit…

e2f76ca

…ely wrong one. I'm going to try to move these files into the correct branch antti/feedback-after-logout" This reverts commit fb04e6d.

vercel bot deployed to Preview June 6, 2024 10:59 View deployment

anttiasmala commented Jun 6, 2024

View reviewed changes

vercel bot deployed to Preview August 12, 2024 10:13 View deployment

Updated small packages

6d1d1f2

samuliasmala requested changes Aug 31, 2024

View reviewed changes

icons/arrow_right_start_on_rectangle.tsx Outdated Show resolved Hide resolved

shared/isValidFunctions.ts Outdated Show resolved Hide resolved

utils/fonts.ts Outdated Show resolved Hide resolved

pages/_app.tsx Show resolved Hide resolved

anttiasmala added 5 commits September 1, 2024 22:15

Changed stroke to be currentColor instead of white color

ce492a1

Removed stroke-white value from className due to it has no usage

fea8a04

Deleted shared/isValidFunctions.ts file due to no usage

37d96cf

Removed roboto_mono font, kept inter still due to it is used in two p…

f67e457

…laces

Changed default font to be Jost. Removed Jost fonts that are not need…

fed9cc5

…ed anymore so code is a bit more clear

vercel bot deployed to Preview September 2, 2024 11:11 View deployment

anttiasmala commented Sep 2, 2024

View reviewed changes

package.json Outdated Show resolved Hide resolved

anttiasmala commented Sep 2, 2024

View reviewed changes

utils/fonts.ts Outdated Show resolved Hide resolved

anttiasmala requested a review from samuliasmala September 2, 2024 11:15

Removed unused import

087bf01

vercel bot deployed to Preview September 2, 2024 11:52 View deployment

samuliasmala requested changes Sep 2, 2024

View reviewed changes

package.json Outdated Show resolved Hide resolved

icons/arrow_right_start_on_rectangle.tsx Outdated Show resolved Hide resolved

anttiasmala added 4 commits September 2, 2024 17:56

Deleted components/InfoModal.tsx, not in use

3176010

Removed Inter font in /utils/font.ts. It is not in use anymore

f91619a

Updated eslint-config-next package and lowered typescript to version …

25c2559

…5.4.5 due to ESLint 8.57.0's last typescript version is apparently <5.5.0. ESLint version 9 does not work currently with Next's Lint check

Changed rest of the SVG images to have currentColor instead of some o…

582ce72

…ther given color

vercel bot deployed to Preview September 2, 2024 15:34 View deployment

anttiasmala commented Sep 2, 2024

View reviewed changes

icons/pencil_edit.tsx Show resolved Hide resolved

anttiasmala commented Sep 2, 2024

View reviewed changes

pages/index.tsx Show resolved Hide resolved

anttiasmala commented Sep 2, 2024

View reviewed changes

components/InfoModal.tsx Show resolved Hide resolved

anttiasmala requested a review from samuliasmala September 2, 2024 15:55

samuliasmala approved these changes Sep 2, 2024

View reviewed changes

anttiasmala merged commit 003c959 into main Sep 2, 2024
5 checks passed

anttiasmala deleted the antti/frontend branch September 2, 2024 20:45

anttiasmala mentioned this pull request Sep 19, 2024

Pakettien päivittäminen | Antti/update-packages #37

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Antti/frontend #27

Antti/frontend #27

anttiasmala commented May 17, 2024

vercel bot commented May 17, 2024 •

edited

Loading

anttiasmala left a comment

samuliasmala left a comment

samuliasmala left a comment

anttiasmala commented Sep 2, 2024 •

edited

Loading

anttiasmala Sep 2, 2024

samuliasmala Sep 2, 2024

samuliasmala left a comment

Antti/frontend #27

Antti/frontend #27

Conversation

anttiasmala commented May 17, 2024

vercel bot commented May 17, 2024 • edited Loading

anttiasmala left a comment

Choose a reason for hiding this comment

samuliasmala left a comment

Choose a reason for hiding this comment

samuliasmala left a comment

Choose a reason for hiding this comment

anttiasmala commented Sep 2, 2024 • edited Loading

anttiasmala Sep 2, 2024

Choose a reason for hiding this comment

samuliasmala Sep 2, 2024

Choose a reason for hiding this comment

samuliasmala left a comment

Choose a reason for hiding this comment

vercel bot commented May 17, 2024 •

edited

Loading

anttiasmala commented Sep 2, 2024 •

edited

Loading