Skip to content

Commit

Permalink
Fix macOS build issue (#129)
Browse files Browse the repository at this point in the history
Specifically, I've updated actions/setup-go to v5, and removed
maxim-lobanov/setup-xcode@v1. According to the comment, this was
required until the GitHub macOS runner was 11.x based, and according to
https://github.com/actions/runner-images it is now on macOS 14.

We also now upload CI build artifacts, which is useful for testing
purposes.
  • Loading branch information
samuong authored Jun 25, 2024
1 parent c317ce0 commit 54aef00
Showing 1 changed file with 8 additions and 9 deletions.
17 changes: 8 additions & 9 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
steps:
- uses: actions/checkout@v2

- uses: actions/setup-go@v1
- uses: actions/setup-go@v5
with:
go-version: ${{ matrix.go }}

Expand All @@ -43,7 +43,7 @@ jobs:
steps:
- uses: actions/checkout@v2

- uses: actions/setup-go@v1
- uses: actions/setup-go@v5
with:
go-version: ${{ matrix.go }}

Expand Down Expand Up @@ -75,16 +75,10 @@ jobs:
steps:
- uses: actions/checkout@v2

- uses: actions/setup-go@v1
- uses: actions/setup-go@v5
with:
go-version: ${{ matrix.go }}

# xcode required until github macos runner is 11.x based
- uses: maxim-lobanov/setup-xcode@v1
if: matrix.target.goos == 'darwin' && matrix.target.goarch == 'arm64'
with:
xcode-version: latest

- if: matrix.target.goos == 'darwin' && matrix.target.goarch == 'arm64'
run: |
echo SDKROOT=$(xcrun --sdk macosx --show-sdk-path) >> $GITHUB_ENV
Expand All @@ -95,3 +89,8 @@ jobs:
GOOS: ${{ matrix.target.goos }}
GOARCH: ${{ matrix.target.goarch }}
CGO_ENABLED: 1
- uses: actions/upload-artifact@v4
with:
name: alpaca-${{ matrix.target.goos }}-${{ matrix.target.goarch }}
path: alpaca

0 comments on commit 54aef00

Please sign in to comment.