Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep solr fields encapsulated within the SolrDocument #828

Merged
merged 1 commit into from
May 31, 2016

Conversation

jcoyne
Copy link
Contributor

@jcoyne jcoyne commented May 31, 2016

No description provided.

end

# Method to return the ActiveFedora model
def hydra_model
self[Solrizer.solr_name('active_fedora_model', Solrizer::Descriptor.new(:string, :stored, :indexed))]
fetch(Solrizer.solr_name('has_model', :symbol)).first.constantize
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the change from active_fedora_model to has_model?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because has_model_ssim is used throughout the stack. samvera/active_fedora#1093

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@coveralls
Copy link

Coverage Status

Coverage remained the same at 91.503% when pulling 04b5516 on refactor_model into b3238e0 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 91.473% when pulling cc7bc8d on refactor_model into b3238e0 on master.

@mjgiarlo mjgiarlo merged commit f4f3603 into master May 31, 2016
@mjgiarlo mjgiarlo deleted the refactor_model branch May 31, 2016 21:22
jcoyne added a commit that referenced this pull request May 31, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants