Adds Jest, Vue test utils, and a test suite for the VanillaVueInput component #33
Conversation
|
Unfortunately vuejs/vue-jest#160 (comment) was a problem, otherwise one would not need to include |
| it('renders the correct markup', () => { | ||
| expect(wrapper.html()).toContain("<form>\n <fieldset><input type=\"text\" placeholder=\"Type a value here...\"></fieldset>\n <p>Value: </p>\n</form>") | ||
| }) | ||
| }) |
There was a problem hiding this comment.
Hey @jrgriffiniii until we get to #30 , mind installing a Prettier extension in your IDE, and set it to default settings? Otherwise if we're both working on similar files the diffs are going to be a of of quotation marks and semicolons:)
There was a problem hiding this comment.
Also, just a thought, what about renaming the file using kebab case to establish a pattern for .js files? I know it's a small thing and no big deal, but I've found switching between lots of different projects, just quick eye glancing files, when I see kebab case I know its JS, and snake case (is that what it's called?) I know it's generally Ruby, Elixir, etc.
assets/package.json
Outdated
| @@ -3,7 +3,8 @@ | |||
| "license": "MIT", | |||
| "scripts": { | |||
| "deploy": "webpack --mode production", | |||
| "watch": "webpack --mode development --watch" | |||
| "watch": "webpack --mode development --watch", | |||
| "test": "jest --config ./js/test/jest.conf.js --coverage" | |||
There was a problem hiding this comment.
Curious if there's a way to reference this file path ./js/test/jest.conf.js outside of the command? Jest might by default look for certain config file(s) where we could declare it? If not, no big deal.
jrgriffiniii
changed the title
jrgriffiniii
changed the title
There was a problem hiding this comment.
@jrgriffiniii This looks great. I've been building on top of it... do you want to merge this as-is, or should I add commits on top, then merge the whole feature branch in at once?
|
I would support merging this as-is please. This would permit you to then continue your progress based off of the |
assets/package.json
Outdated
| "!<rootDir>/js/components/_components.js", | ||
| "!<rootDir>/js/components/_lux-elements-used.js", | ||
| "!<rootDir>/node_modules/**" | ||
| ] | ||
| } | ||
| } |
There was a problem hiding this comment.
@jrgriffiniii I was probably unclear in a previous PR comment, but I liked how you had these jest configs in the previous jest config file. What I meant to say was that we might not (not positive) need to declare the path to jest.config.js or whatever the file is called, in the test npm command.
Either way, no big deal. Tested, and locally runs as expected. Again, nice work. I'll save my work on top of this and do a PR in the near future to expand some testing scenarios with embedded components and other more advanced scenarios which will pop up in a future app.
There was a problem hiding this comment.
Apologies for that, I have restored this with 92ca869
jrgriffiniii
force-pushed
the
issues-26-jrgriffiniii-vanilla-vue-input-test
branch
from
c5c9aa0 to
074ea91
Compare
|
The tests should fail given that I am specifying a required threshold of 100% test coverage for the Jest test suites with 92ca869#diff-8b1e675a9fa0a68d9c4f68b81f920a74R20 |
components; Introduces a Jest configuration file for generating test coverage reports and handling .vue templates; Adds a test suite for the VanillaVueInput component Co-authored-by: Adam Arling <adam.arling@northwestern.edu>
…e Jest configuration into the package.json file
…s pass for the initial PR
jrgriffiniii
force-pushed
the
issues-26-jrgriffiniii-vanilla-vue-input-test
branch
from
304e0d5 to
317d113
Compare
jrgriffiniii
deleted the
issues-26-jrgriffiniii-vanilla-vue-input-test
branch
Advances #26 with the following:
coverage reports and handling .vue templates