Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contribute back from pals #19

Merged
merged 7 commits into from
Jul 15, 2024
Merged

Contribute back from pals #19

merged 7 commits into from
Jul 15, 2024

Conversation

kirkkwang
Copy link
Contributor

@kirkkwang kirkkwang commented Jul 12, 2024

Related Issue:

Update generator

6ce1ecd

Update engine

da485d7

Update rails_helper

f25ff64

Wrap Hyrax initializer in after_initialize

5fa90da

Update Dockerfile

997fcde

Update submodule

89eb35a

Update Gemfile.lock

c9ac6da

ShanaLMoore
ShanaLMoore previously approved these changes Jul 12, 2024
@ShanaLMoore ShanaLMoore dismissed their stale review July 12, 2024 15:09

Actually, shouldn't this also update the submodule to hyku v6.0.0?

Copy link
Contributor

@ShanaLMoore ShanaLMoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for picking this up @kirkkwang

Should this PR also include the submodule pointing to Hyku v6.0.0?

@kirkkwang
Copy link
Contributor Author

@ShanaLMoore Yes the submodule has been updated, it was done in this commit 89eb35a

Copy link
Contributor

@ShanaLMoore ShanaLMoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏿

@ShanaLMoore ShanaLMoore merged commit 63f9c94 into main Jul 15, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants