Skip to content
This repository has been archived by the owner on Mar 20, 2023. It is now read-only.

Use new Hyrax devise styles #311

Merged
merged 2 commits into from
Nov 14, 2018
Merged

Conversation

no-reply
Copy link

This takes advantage of the new login form styles in samvera/hyrax#3362.

This takes advantage of the new login form styles in
samvera/hyrax#3362.
@bess
Copy link

bess commented Nov 13, 2018

@no-reply CI is failing :(

  1) Create a GenericWork a logged in user 
     Failure/Error: Unable to find matching line in /home/travis/build/curationexperts/nurax/app/assets/stylesheets/hyrax.scss
     
     Sass::SyntaxError:
       File to import not found or unreadable: hyrax/login_signup.

@no-reply
Copy link
Author

@bess it looks like CI is running an older version of Hyrax than the actual builds. https://travis-ci.org/curationexperts/nurax/builds/454710578#L1199

This is probably because Gemfile.lock is checked in. We could add a bundle update hyrax to the build, or simply drop Gemfile.lock. I'm guessing the bundle option is more like what's happening on the nightlies?

Ran with 'bundle update hyrax`.
@bess bess merged commit 034bd24 into samvera-labs:master Nov 14, 2018
@no-reply no-reply deleted the hyrax-devise-styles branch November 16, 2018 17:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants