Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SRT/VTT timestamp validation to deny single digit hour in hh:mm... #546

Merged
merged 2 commits into from
Jul 2, 2024

Conversation

Dananji
Copy link
Collaborator

@Dananji Dananji commented Jul 1, 2024

Related issue: #537

Display a message when at least one of the timestamps in SRT/VTT cues are invalid:

Screenshot 2024-07-01 at 3 34 43 PM

Copy link
Member

@cjcolvar cjcolvar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I just had one small suggestion.

src/services/transcript-parser.js Show resolved Hide resolved
@Dananji Dananji merged commit 7465d96 into main Jul 2, 2024
2 checks passed
@Dananji Dananji deleted the timestamp-validation branch July 2, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants