Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update variables in progress component to refs to maintain accuracy with canvas updates #587

Merged
merged 4 commits into from
Jul 26, 2024

Conversation

Dananji
Copy link
Collaborator

@Dananji Dananji commented Jul 23, 2024

Related issue: #560

Merge this after 7.8 related Ramp release is created

After some discussion in Slack it was decided to merge this for 7.8 release since this has similar scope as #580 which is going to be in 7.8.

@Dananji Dananji marked this pull request as ready for review July 25, 2024 17:18
@Dananji Dananji marked this pull request as draft July 26, 2024 14:04
@Dananji Dananji marked this pull request as ready for review July 26, 2024 14:21
Copy link
Member

@cjcolvar cjcolvar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good as far as I can tell.

@Dananji Dananji merged commit 9d3940c into main Jul 26, 2024
2 checks passed
@Dananji Dananji deleted the safari-playback-fix-560 branch July 26, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants