ActiveFedora::File.mime_type should be updatable #1035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cjcolvar It looks like rubocop found some issues with your changes. Can you run |
cjcolvar
force-pushed
the
file_mime_types_cjcolvar
branch
from
1664dda
to
f015ae4
Compare
| @@ -45,7 +46,7 @@ def save | |||
|
|
|||
| def changed_attributes | |||
| super.tap do |changed| | |||
| changed['type'] = true if type.present? | |||
| changed['type'] = true if type.present && new_record? | |||
There was a problem hiding this comment.
It looks like the method is missing a question mark present?
cjcolvar
force-pushed
the
file_mime_types_cjcolvar
branch
from
f015ae4
to
cd865de
Compare
Squash and rebase of file_mime_types branch by @tpendragon
|
@cjcolvar I'm going to revert this commit, because it puts FCrepo 4.5.0 into a bad state. See samvera-deprecated/curation_concerns#693 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Squash and rebase of file_mime_types branch by @tpendragon