SolrHit#instantiate_with_json should create persisted objects #1056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@barmintor, can you please review this and see if it fixes things? |
|
What? That was the bug? 👍 |
|
Not sure. It was one thing I tripped across trying to recreate the bug in the first place, and I'm hoping it's related. |
|
I am chasing down various dependency conflicts preventing me from testing this in my sufia7 app, the latest is that hydra-access-controls has not been released and is not a github repo, so it's released pin of AF ~> 9.10.x is in effect, barring AF master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1054