Performance Improvements #1109
Merged
Performance Improvements #1109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shares an in-memory repository between the LDP graph and the AF::Base's resource. Reduces graph copying by a significant amount.
| @@ -43,7 +43,7 @@ def resource | |||
| # Appending the graph at the end is necessary because adding it as the | |||
| # parent leaves behind triples not related to the ldp_source's rdf | |||
| # subject. | |||
| @resource ||= self.class.resource_class.new(@ldp_source.graph.rdf_subject, @ldp_source.graph) << @ldp_source.graph | |||
| @resource ||= self.class.resource_class.new(@ldp_source.graph.rdf_subject, data: @ldp_source.graph.send(:graph).data) | |||
There was a problem hiding this comment.
Should a ticket be opened upstream to change the visibility to public?
There was a problem hiding this comment.
@no-reply Should we make AT::Resource's graph public, or just delegate data?
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shares an in-memory repository between the LDP graph and the AF::Base's
resource. Reduces graph copying by a significant amount.
Also adds an ids reader to ordered associations which doesn't instantiate objects.