Loosened Rubydora dependency for 2.x. #1200
Conversation
| @@ -11,3 +11,4 @@ end | |||
| gem 'jruby-openssl', :platform=> :jruby | |||
| gem 'activemodel', ENV['RAILS_VERSION'] if ENV['RAILS_VERSION'] | |||
| gem 'linkeddata', '~> 1.99' | |||
| gem 'rake', '< 12' | |||
There was a problem hiding this comment.
why are you changing this dependency?
There was a problem hiding this comment.
I guess rspec 2.99 tasks not compatible with rake 12.
$ rake ci
rake aborted!
NoMethodError: undefined method `last_comment' for #<Rake::Application:0x007f96fb031fa8>
/Users/dc/.rvm/gems/ruby-2.3.1@active-fedora/gems/rspec-core-2.99.2/lib/rspec/core/rake_task.rb:143:in `initialize'
lib/tasks/active_fedora_dev.rake:28:in `new'
lib/tasks/active_fedora_dev.rake:28:in `block in <top (required)>'
lib/tasks/active_fedora_dev.rake:7:in `<top (required)>'
/Users/dc/github/projecthydra/active_fedora/Rakefile:10:in `load'
/Users/dc/github/projecthydra/active_fedora/Rakefile:10:in `<top (required)>'
There was a problem hiding this comment.
Why not upgrade rspec to rspec 3?
There was a problem hiding this comment.
Upgrading to RSpec 3.5 creates 72 test failures.
There was a problem hiding this comment.
Have you tried using http://yujinakayama.me/transpec/ ?
There was a problem hiding this comment.
@dchandekstark Chris informs me that he already ran transpec on AF 8. Is there some reason you are using AF 7?
There was a problem hiding this comment.
Well, I wanted to use AF 8, but discovered that the bump to ActiveTriples 0.4.x was a problem, so was trying to go this route.
There was a problem hiding this comment.
Just pinning rake to < 12 seemed the easiest solution all around given that I just want to be able to use Rubydora 2.0.0.
No description provided.